5 ms·

I'm not sure this is ready for prime time: 1.54MB - https://github.com/aws/aws-amplify/blob/master/packages/aws-amplify/dist/aws-amplify.min.js https://github.

I'm not sure this is ready for prime time: 1.54MB - https://github.com/aws/aws-amplify/blob/master/packages/aws-amplify/dist/aws-amplify.min.js https://github.com/aws/aws-amplify/blob/master/packages/aws-...

jrs95 9y ago
That's why they're not limiting access to Prime subscribers yet ;)
eloff 9y ago
Amplify sure lives up to its name...
tanilama 9y ago
This feels wrong
Cthulhu_ 9y ago
I'm looking at the source itself, looks like it's got everything and the kitchen sink; I'm seeing XML datastructures, lodash-like utils, HTTP API handling, local storage (probably from the caching they mentioned), a script interpreter, buffers (very large section), etc. It's just go a lot of Stuff in it. Strong NIH feeling.
richardzcode 9y ago
Hi this has been updated and the new size is 511KB which you can see here: https://github.com/aws/aws-amplify/blob/master/packages/aws-amplify/dist/aws-amplify.min.js https://github.com/aws/aws-amplify/blob/master/packages/aws-...
powerful23 9y ago
Hi, this has been updated and the new size is 524KB which you can see here: https://github.com/aws/aws-amplify/tree/master/packages/aws-amplify/dist https://github.com/aws/aws-amplify/tree/master/packages/aws-... and https://www.npmjs.com/package/aws-amplify https://www.npmjs.com/package/aws-amplify
- timdorr 9y ago
  That's a good start! One bigger issue is you're storing built assets in source control. This is considered bad practice, as it creates a lot of noise in commits and bogs down git clients with tons of unnecessary blobs. git is for source code, npm is for transpiled code and UMD bundles. You should "retcon" your repo, by removing them from history with filter-branch (the same process as with sensitive data removal: https://help.github.com/articles/removing-sensitive-data-from-a-repository/ https://help.github.com/articles/removing-sensitive-data-fro...), make sure they're .gitignore'd, and only publish the built assets in your npm packages (use the "files" option in package.json).

jrs95 9y ago

That's why they're not limiting access to Prime subscribers yet ;)

eloff 9y ago

Amplify sure lives up to its name...

tanilama 9y ago

This feels wrong

Cthulhu_ 9y ago

I'm looking at the source itself, looks like it's got everything and the kitchen sink; I'm seeing XML datastructures, lodash-like utils, HTTP API handling, local storage (probably from the caching they mentioned), a script interpreter, buffers (very large section), etc. It's just go a lot of Stuff in it. Strong NIH feeling.

richardzcode 9y ago

Hi this has been updated and the new size is 511KB which you can see here: https://github.com/aws/aws-amplify/blob/master/packages/aws-amplify/dist/aws-amplify.min.js https://github.com/aws/aws-amplify/blob/master/packages/aws-...

powerful23 9y ago

Hi, this has been updated and the new size is 524KB which you can see here: https://github.com/aws/aws-amplify/tree/master/packages/aws-amplify/dist https://github.com/aws/aws-amplify/tree/master/packages/aws-... and https://www.npmjs.com/package/aws-amplify https://www.npmjs.com/package/aws-amplify

timdorr 9y ago
That's a good start! One bigger issue is you're storing built assets in source control. This is considered bad practice, as it creates a lot of noise in commits and bogs down git clients with tons of unnecessary blobs. git is for source code, npm is for transpiled code and UMD bundles. You should "retcon" your repo, by removing them from history with filter-branch (the same process as with sensitive data removal: https://help.github.com/articles/removing-sensitive-data-from-a-repository/ https://help.github.com/articles/removing-sensitive-data-fro...), make sure they're .gitignore'd, and only publish the built assets in your npm packages (use the "files" option in package.json).