3 ms·
I'm sympathetic to the cause, but this example would not serve well a noob trying to dive into the subject. * It does not work (bug in node Dockerfile) * It r
by avip 9y ago
I'm sympathetic to the cause, but this example would not serve well a noob trying to dive into the subject.
* It does not work (bug in node Dockerfile)
* It requires extra builds (while users expect `docker-compose up` to _just work_)
* There's no tester container to curl something to ensure me it works
* The docker files are half baked - ex. not using layers correctly (npm install called after code COPY), ex. `npm build` redundantly called, ex. using ubuntu:latest rather than golang:onbuild... and so on.
And yes, I guess I could fix all that... submit a PR, and be declared the king of HN. But today I rather just complain.
- bauerd 9y agoonbuild tags are deprecated: https://github.com/docker-library/official-images/issues/2076 https://github.com/docker-library/official-images/issues/207... … although using an onbuild image here wouldn't hurt
- olalonde 9y agoAlso, no data persistence, which is often one of the biggest challenge with microservices.
- akerro 9y agoRight next to distributed logging and failure reporting problems.