4 ms·

> Our Word Detector was also a significant bottleneck. We ended up essentially rewriting OpenCV’s C++ MSER implementation in a more modular way to avoid duplica

> Our Word Detector was also a significant bottleneck. We ended up essentially rewriting OpenCV’s C++ MSER implementation in a more modular way to avoid duplicating slow work when doing two passes (to be able to handle both black on white text as well as white on black text); to expose more to our Python layer (the underlying MSER tree hierarchy) for more efficient processing; and to make the code actually readable. Was this ever contributed back to opencv?

qume 9y ago
Looking forward to seeing this Dropbox. If someone there is reading this, please release this code in any way you like, even if you think it's too rushed or ugly, i'm sure the community can clean it up.
turblety 9y ago
OpenCV is licensed under the BSD license. [1] "BSD (unlike some other licenses) does not require that source code be distributed at all." [2] Looks like there is no legal obligation to provide their source code or changes. But I really hope they did push their changes upstream. It is a real shame when companies that benefit so much from the open source community don't give back. 1. https://github.com/opencv/opencv/blob/master/LICENSE https://github.com/opencv/opencv/blob/master/LICENSE 2. https://en.wikipedia.org/wiki/BSD_licenses https://en.wikipedia.org/wiki/BSD_licenses
- aidenn0 9y ago
  Even under GPL there would be no requirement, since this happens on the server, not the client. The AGPL is the only license I'm aware of that places this requirement when not distributing the software.
- wiz21c 9y ago
  Hopefully, those who miss that Dropbox code today may think about using a more powerful license (ie AGPL) on the code they'll write themselves in the future so that they make sure their users will contribute back like they want DropBox to. :-)
  - wwarner 9y ago
    Pretty sure that both OpenCV and Dropbox knew what they were doing when they avoided the affero license.

qume 9y ago

Looking forward to seeing this Dropbox. If someone there is reading this, please release this code in any way you like, even if you think it's too rushed or ugly, i'm sure the community can clean it up.

turblety 9y ago

OpenCV is licensed under the BSD license. [1] "BSD (unlike some other licenses) does not require that source code be distributed at all." [2] Looks like there is no legal obligation to provide their source code or changes. But I really hope they did push their changes upstream. It is a real shame when companies that benefit so much from the open source community don't give back. 1. https://github.com/opencv/opencv/blob/master/LICENSE https://github.com/opencv/opencv/blob/master/LICENSE 2. https://en.wikipedia.org/wiki/BSD_licenses https://en.wikipedia.org/wiki/BSD_licenses

aidenn0 9y ago
Even under GPL there would be no requirement, since this happens on the server, not the client. The AGPL is the only license I'm aware of that places this requirement when not distributing the software.
wiz21c 9y ago
Hopefully, those who miss that Dropbox code today may think about using a more powerful license (ie AGPL) on the code they'll write themselves in the future so that they make sure their users will contribute back like they want DropBox to. :-)
- wwarner 9y ago
  Pretty sure that both OpenCV and Dropbox knew what they were doing when they avoided the affero license.