3 ms·

Completely agree. The new react router is a massive step back in the same code base. Rewriting apps in the new version is a massive pain.

by buf 9y ago

tedeh 9y ago
That is true, but the new react-router makes better use of the component hierarchy which is the real beauty of React IMHO, by having the route components render conditionally based on the url. We had a lot of pain doing this rewrite ourselves, but I must say it was worth it in the end. Unfortunately, this is major version 4, so who is to say that the repo maintainers don't find an even better way to do it in six months, prompting a version 5 and so on...
- timdorr 9y ago
  React Router maintainer here! The only things we're looking at for another major version are some changes to the default API behaviors (making `exact` default to true, for instance). There are potentially some changes to path matching, but that's being driven by path-to-regexp, not our own development. Yes, 4.0 was a big change, but a necessary one. Now that we're in a great place, we plan on keeping things relatively stable indefinitely. Pencils down, as it were. Outside of some major upstream change with React itself, future versions will be more evolutionary than revolutionary.
  - davnicwil 9y ago
    Happy react router user here, at various major versions. Thanks for the great work! > Yes, 4.0 was a big change, but a necessary one. Now that we're in a great place, we plan on keeping things relatively stable indefinitely. Out of curiosity, was this also the thinking when 3.x was released? Or when 3.x was released was there more of a philosophy that the problem space was still being explored, and major design changes were still possible and acceptable?
    - timdorr 9y ago
      3.0 just removed deprecated features from 2.0. There were a handful of other tiny things, but a pretty bland major release otherwise.
      - davnicwil 9y ago
        Sure, but whether or not 3.x changed significantly from 2.x isn't really what I'm asking about, I was more wondering if you imagined upon the release of 3 (or 2 for that matter) that it was more or less the final stable overall design, or were significant future redesigns/rewrites still in the plan at that point?

Completely agree. The new react router is a massive step back in the same code base. Rewriting apps in the new version is a massive pain.

by buf 9y ago

Completely agree. The new react router is a massive step back in the same code base. Rewriting apps in the new version is a massive pain.

tedeh 9y ago

That is true, but the new react-router makes better use of the component hierarchy which is the real beauty of React IMHO, by having the route components render conditionally based on the url. We had a lot of pain doing this rewrite ourselves, but I must say it was worth it in the end. Unfortunately, this is major version 4, so who is to say that the repo maintainers don't find an even better way to do it in six months, prompting a version 5 and so on...

timdorr 9y ago
React Router maintainer here! The only things we're looking at for another major version are some changes to the default API behaviors (making `exact` default to true, for instance). There are potentially some changes to path matching, but that's being driven by path-to-regexp, not our own development. Yes, 4.0 was a big change, but a necessary one. Now that we're in a great place, we plan on keeping things relatively stable indefinitely. Pencils down, as it were. Outside of some major upstream change with React itself, future versions will be more evolutionary than revolutionary.
- davnicwil 9y ago
  Happy react router user here, at various major versions. Thanks for the great work! > Yes, 4.0 was a big change, but a necessary one. Now that we're in a great place, we plan on keeping things relatively stable indefinitely. Out of curiosity, was this also the thinking when 3.x was released? Or when 3.x was released was there more of a philosophy that the problem space was still being explored, and major design changes were still possible and acceptable?
  - timdorr 9y ago
    3.0 just removed deprecated features from 2.0. There were a handful of other tiny things, but a pretty bland major release otherwise.
    - davnicwil 9y ago
      Sure, but whether or not 3.x changed significantly from 2.x isn't really what I'm asking about, I was more wondering if you imagined upon the release of 3 (or 2 for that matter) that it was more or less the final stable overall design, or were significant future redesigns/rewrites still in the plan at that point?