4 ms·
I've never been in a culture where reviewers add commits to a topic branch they're reviewing! If I may, what have you found the pros and cons to be, compared to
by throwanem 9y ago
I've never been in a culture where reviewers add commits to a topic branch they're reviewing! If I may, what have you found the pros and cons to be, compared to what I guess might be the more usual style?
- mrgriffin 9y agoWe're pretty conservative with the things we add, it's 95% correcting comments/documentation and the other 5% minor (behavior-preserving) transformations. We work in Python, so those transformations are things like using `collections.defaultdict` instead of a plain dictionary where it makes sense etc etc.