4 ms·

> No code review needs to be passed before pushing to trunk. It is the responsibility of the developer to write good code. Yowsa! This sounds like developers w

• valuearb 9y ago
  The first job I ever had, I had brutal code reviews from a great developer. I never enjoyed them, but appreciate them now. I haven't had code reviews since, until my new job. Where every PR is supposed to be code reviewed. I really enjoy the idea that someone will find problems in my code and suggest better ways to do it so I can further develop my skills. I also spend lots of time coaching junior developers, and like that I can review their PR's to see if my coaching is helping, or if they still need help with concepts. Writing solid code bases without code reviews seems like a fantasy. Deferring code reviews until a huge new branch is complete and expecting a busy engineer to review the whole thing, and then suggest improvements, and have the original developer then decide to rewrite the entire branch to incorporate them, also seems like a fantasy.