49 ms·
You seem have a problem in Safari 4. If I select the bookmarklet text, then drag it to the bookmarks bar, then only the first line was added as a bookmark. [NO
by watmough 16y ago
You seem have a problem in Safari 4. If I select the bookmarklet text, then drag it to the bookmarks bar, then only the first line was added as a bookmark.
[NOTE: I just noticed there is an actual bookmark as I suggested below. OK.]
I ended up editing the breaks out of the text to get the bookmark to work.
You should probably bury the bookmarklet text in a link, and have the user drag that to the bookmarks bar.
Also, you are not sniffing Safari 4 correctly. I get a message that it is an unrecognized browser!
- StavrosK 16y agoOh, thanks for that, we'll fix it right away!
- woodall 16y ago>Also, you are not sniffing Safari 4 correctly. I get a message that it is an unrecognized browser! I would be careful about this. Sniffing browsers isn't always a good idea. Instead, let users drag their own bookmarklet- that correspond with their browser type- to the toolbar. Or keep sniffing and if you do receive an "unrecognized browser" response fall back to a page of that type.
- StavrosK 16y agoThe bookmarklet is the same, the sniffing is for the instructions. The problem is that we want the code below to be the same as the one in the bookmarklet, so we use the same file for both, but for some reason newlines are not removed. I will change that now to make it work with Safari...
- StavrosK 16y agoI'm sorry, do you mean that the actual bookmarklet doesn't work, or the text below? You're only supposed to use the text if the bookmarklet fails, we just wrap it for display...