5 ms·

Hi, You're using large parts of WebKit source code (LGPL) in your proprietary library. This is against the license. Please compare: https://github.com/yue/yue

Hi, You're using large parts of WebKit source code (LGPL) in your proprietary library. This is against the license. Please compare: https://github.com/yue/yue/blob/master/nativeui/gfx/gtk/painter_gtk.cc#L90 https://github.com/yue/yue/blob/master/nativeui/gfx/gtk/pain... https://github.com/WebKit/webkit/blob/master/Source/WebCore/platform/graphics/cairo/PathCairo.cpp#L206 https://github.com/WebKit/webkit/blob/master/Source/WebCore/...

drinchev 9y ago
Wow, that's very bad. Created an issue for this to prevent anyone else using it. Let's see how the author will respond. https://github.com/yue/help/issues/4 https://github.com/yue/help/issues/4
- GuiA 9y ago
  Your last sentence, "How would you respond to these?", is fairly passive-aggressive. Pointing out the issue (use of LGPL code with a license that does not permit it) is sufficient.
  - drinchev 9y ago
    Fixed
    - tomcam 9y ago
      Gracefully done. Thanks
- kevinfan0 9y ago
  Should his employer be responsible for this? I just created an issue for BEIPA on this topic: https://github.com/github/balanced-employee-ip-agreement/issues/58 https://github.com/github/balanced-employee-ip-agreement/iss...
Doctor_Fegg 9y ago
That's LGPL, not GPL.
- Jasper_ 9y ago
  Oops, I misread the license header. Fixed. You still can't relicense LGPL as MS-PL, though.
aaron-lebo 9y ago
Is this guy just a bad citizen of the dev community? https://news.ycombinator.com/item?id=15219048 https://news.ycombinator.com/item?id=15219048
fiatjaf 9y ago
I don't see that the author has clearly copied anything there. Maybe he did, maybe he didn't. This situation only proves open-source licensing is in a bad shape. Actually it is horrible. See, for example, the criticisms and questions being raised on the whole thread about this library. (Until anyone point a better alternative, I'm for "if you don't want anyone using them, don't publish your sources".)
- Jasper_ 9y ago
  The comments, flow control and variable names are the exact same, and the comments at the top of the file have the same emails as the WebKit source code. If that's not a clear cut sign of plagarism, I don't know what is.
smegel 9y ago
> You're using large parts of WebKit source code (LGPL) in your proprietary library. This is against the license. What makes it proprietary?
- Jasper_ 9y ago
  For some reason I thought MS-RL wasn't an OSI-approved license, but it appears it is: https://opensource.org/licenses/alphabetical https://opensource.org/licenses/alphabetical Bad choice of words on my part, and I can't correct my comment anymore. That said, LGPL works still aren't compatible with MS-RL, so you can't distribute the combined work as MS-RL.

drinchev 9y ago

Wow, that's very bad. Created an issue for this to prevent anyone else using it. Let's see how the author will respond. https://github.com/yue/help/issues/4 https://github.com/yue/help/issues/4

GuiA 9y ago
Your last sentence, "How would you respond to these?", is fairly passive-aggressive. Pointing out the issue (use of LGPL code with a license that does not permit it) is sufficient.
- drinchev 9y ago
  Fixed
  - tomcam 9y ago
    Gracefully done. Thanks
kevinfan0 9y ago
Should his employer be responsible for this? I just created an issue for BEIPA on this topic: https://github.com/github/balanced-employee-ip-agreement/issues/58 https://github.com/github/balanced-employee-ip-agreement/iss...

Doctor_Fegg 9y ago

That's LGPL, not GPL.

Jasper_ 9y ago
Oops, I misread the license header. Fixed. You still can't relicense LGPL as MS-PL, though.

aaron-lebo 9y ago

Is this guy just a bad citizen of the dev community? https://news.ycombinator.com/item?id=15219048 https://news.ycombinator.com/item?id=15219048

fiatjaf 9y ago

I don't see that the author has clearly copied anything there. Maybe he did, maybe he didn't. This situation only proves open-source licensing is in a bad shape. Actually it is horrible. See, for example, the criticisms and questions being raised on the whole thread about this library. (Until anyone point a better alternative, I'm for "if you don't want anyone using them, don't publish your sources".)

Jasper_ 9y ago
The comments, flow control and variable names are the exact same, and the comments at the top of the file have the same emails as the WebKit source code. If that's not a clear cut sign of plagarism, I don't know what is.

smegel 9y ago

> You're using large parts of WebKit source code (LGPL) in your proprietary library. This is against the license. What makes it proprietary?

Jasper_ 9y ago
For some reason I thought MS-RL wasn't an OSI-approved license, but it appears it is: https://opensource.org/licenses/alphabetical https://opensource.org/licenses/alphabetical Bad choice of words on my part, and I can't correct my comment anymore. That said, LGPL works still aren't compatible with MS-RL, so you can't distribute the combined work as MS-RL.