3 ms·
Reviewing and either accepting or rejecting (in full, no need to cherry-pick) large PR's is entirely up to the author. You were right; the safest way is to sim
by jamiesonbecker 9y ago
Reviewing and either accepting or rejecting (in full, no need to cherry-pick) large PR's is entirely up to the author.
You were right; the safest way is to simply ask if they're willing to sponsor that custom work, and how would they like to be credited for their sponsorship.
There's no need to go crazy about it. If it's not a right fit for the project or too much effort for the maintainer, then they can pay or it will just go undone. No one has to sell out in order to simply ask for someone to sponsor a feature.. it's simply logical to just ask for a contract or donation, or reject the PR if it's too big.
- brooklynrob 9y agoYes. That sounds reasonable. The problem comes that, as with many things, people like to live others' values for them. People become unreasonable. My friend was worried that he'd lose the respect, unreasonably in my view, of the community for not doing the "right thing", which in his view was dealing with a feature and set of PRs that were not on the roadmap to happen just now. And that word "sell out" - his word - for asking to be paid for his time was the root fear.
- jamiesonbecker 9y agoUnderstood completely and agreed.. but (almost) everyone has to 'sell out' by taking a job. A bit of reticence in this area is noble but perhaps misplaced, and people who get at least somewhat comfortable in asking for other people's money (aka selling out) might tend to not have as many concerns about money or pull requests. ;)