4 ms·
Maybe I'm being a little picky, but I don't find this very compelling. There are plenty of spelling and consistency errors. "Colaboration" is misspelled. The na
by DanielStraight 16y ago
Maybe I'm being a little picky, but I don't find this very compelling. There are plenty of spelling and consistency errors. "Colaboration" is misspelled. The names "can_use_editor" and "is_acceptable_workstation" are inconsistent. It would be better to use "is_acceptable_editor" (or "can_use_workstation") for consistency. Actually, since those are calls on a company object, a name like, "allows_editor" would make a lot more sense. Coding style doesn't follow Python conventions (spaces around equals sign and after commas). The test "DynamicLanguagesAreInUse" doesn't clearly test what it says it's going to test. Also, the line numbers and lines don't match up in my browser.
- unshift 16y agonot to mention his assertTrue's in testSystemsUpAndRunning are completely invalid. never in my life would i hire this person. this should be a lesson: if you're going to do a "hacker" resume, it should be perfect and actually parse/compile and run. otherwise it looks like some lame gag. and is putting things in "code" ever cute, clever, or funny? i submit it is not.
- enjo 16y agoMy big issue is that he comes across as an ideologue... I want flexibility from developers, not someone who makes very specific demands of our methodology.
- masklinn 16y agoWait, he comes across as an ideologue for asking for an internal bug tracker and a source control system? Or that code be reviewed? Wow...
- jarek 16y ago"Windows? shudders", on the other hand...
- digitallogic 16y agoDo you think you could elaborate? Coming off as inflexible or dictatorial was something I actually worried about. The point I am trying to make is that there are certain minimum requirements I have of any employer, just as almost every job ad I've seen has a list of expected minimum skills. Would you work on software for a company that doesn't use version control? Being on HN is enough to convince me that you're smart enough not to.
- astrec 16y agoOn the other hand I wouldn't hire anyone who wasn't inflexible about having source control, defect tracking, CI, or code reviews. What is important to me, however, is that you demonstrate a little pragmatism about us using Mercurial over Git, Hudson over CC, Jira over Bugzilla, <insert tool we use> vs. <your favourite tool this week>. Although it would reflect better on you if your unit test were valid given an appropriate companies module, I really don't think you should be to worried.
- studer 16y ago> this should be a lesson: if you're going to do a "hacker" resume, it should be perfect and actually parse/compile and run. It does parse/compile and run. Try it.
- generalk 16y agoTraceback (most recent call last): File "/tmp/resume.py", line 2, in <module> from companies import YourCompany ImportError: No module named companies Am I missing something?
- studer 16y agoYeah, you're so completely missing the point of his code that I have to question the intelligence of both yourself and everyone who's upvoted your message. Is this stupid night on Hacker News, or what's going on here? (And yes, I'm 100% serious. Your reply is the dumbest thing I've ever seen on this site.)
- ElliotH 16y agoYup, the companies namespace is theoretical (containing presumably every company in existence) and contains a class YourCompany - that represents the interviewer's company. Because companies doesn't actually exist there is an import error. If you were to create a class to substitute in you'd need something like: class YourCompany: def unit_tests_code(): return True ...
- gaius 16y agoAnd he should stick to one font in his real CV, it looks very amateur.
- famousactress 16y agoYeah, in general I find the code not all that readable, despite that being the point.. This is a pretty bold, maybe even snarky, bit to pull.. and if you're going to pull it off it better be Beautiful Code.
- ErrantX 16y agoThe linked resume is even worse. That would be straight in the rejected pile, sadly.
- digitallogic 16y agoYes, this is quite embarrassing, especially the typos. I sent this to my buddy without expressing that it was still a work in progress, and he overzealously posted it here. I've noticed the line number issue with certain browsers myself. I haven't determined if it is the css/html from pygments (the library I used to generate the html) or something I'm doing. Needless to say since I am still trying to flush out the idea, matching line numbers was low on my list, but if you can give me your browser/os I can see if it can test it out and possibly drop a patch to pygments.
- DanielStraight 16y agoI can appreciate that. I think we've all accidentally made something public at least once. I'm running Firefox 3.6.6 on Windows XP.