3 ms·
These types of issues/pulls are honestly intellectually demeaning. I know you're acting in good faith, but it really feels like MK-Ultra braindrain. Imagine a
by david-cako 9y ago
These types of issues/pulls are honestly intellectually demeaning. I know you're acting in good faith, but it really feels like MK-Ultra braindrain.
Imagine approaching Linus Torvalds at a conference and telling him that you think people who choose to disobey the documented code style (which I, and most others, do not necessarily use outside of Linux kernel code) are just using "non-standard code style".
- Manishearth 9y agoBut this isn't about code style for a repo. If folks don't use the rust code style for contributing to the rust repo, sure, their pulls will be asked to fix it and not merged till they do. But as you yourself mention, folks use different code styles in different places. This is about being clearer about that. The better analogy here is GCC calling non-GNU style C code "bad" in all repos it is run on. Rust as a community is much more uniform wrt code style than C is, which is why the compiler even does things like warn about nonstandard style, but that's just it -- the style is non standard, not intrinsically bad in anyway (and "nonstandard" is better at explaining what's wrong than "bad" is).
- Etzos 9y agoBut it's true that there's nothing inherently "bad" about the code. It's just not conforming to the standard style. It seems pretty reasonable to want that to sound less menacing than "bad code", which would hint very strongly that one has something semantically incorrect.