4 ms·
>Have you ever did a code review, and gave feedback that was longer than doing the fix yourself, while you’re at it? Yes. Yes yes yes. I hate this so much. I w
by alphaalpha101 9y ago
>Have you ever did a code review, and gave feedback that was longer than doing the fix yourself, while you’re at it?
Yes. Yes yes yes. I hate this so much. I want my code reviews to involve fixing little things. I don't even have suggested edits, I can only highlight comments and make comments, and even suggested edits wouldn't be enough. I want to just make the changes. It's all on a branch anyway.
- bowmessage 9y agoYeah, but you miss the training opportunity this way..
- dkubb 9y agoYou could make the comment about the change, then create a fixup commit and allow the original author to decide to merge it or not.
- alphaalpha101 9y agoHow so? It's on the code review. They see the change, and learn about it..? 99.9% of code review that I do, and that I get, is not training. So maybe don't make all the changes for new employees? I use vim. Most people at my work use vim. Our build process is complex. Everything we do is really complicated. It works for the experienced, yet it has a learning curve. So, new people get a slightly different experience. That's fine.