4 ms·
The only part I disagree with is "close the PR if nobody replies". Open PRs without a clear blocker are important indicators of project health. If a PR stays op
by yorwba 9y ago
The only part I disagree with is "close the PR if nobody replies". Open PRs without a clear blocker are important indicators of project health. If a PR stays open for a long time, it might mean that the maintainers have trouble reviewing outside contributions, or aren't that interested in incorporating them. If I see that in a project repo, I think twice about doing the work to contribute when it might end up ignored.
- acdha 9y agoWhat about stepping up to help? Many projects suffer from maintainer overload and it's hugely duplicative to start another project which is likely to repeat the cycle.
- Mazzen 9y agoHad a quick look at the article and this immediately caught my eye. Leave the PR open! The maintainer might need a few more days to respond or might eventually reconsider. Also do not forget about other developers interested in the project. I've more than once merged PRs locally to profit from them before they were merged. Last but not least, open PRs are a good health indicator, I have to agree there.