4 ms·

What are the benefits of reviewers over automated testing? My workflow (which I believe is pretty standard) is: * Write code * Verify that tests pass locally

• sz4kerto 9y ago
  > If all tests pass on Travis, code is stylistically and functionally correct Passing tests don't prove that - tests are covering all functional criteria required - the code doesn't add 'technical debt', i.e. structural problems that will have to be refactored/worked around in the future.
• maaaats 9y ago
  Those things have nothing to do with a PR, other than maybe a PR being a good way to say "this is done, let's automatically verify it". A PR is about showing the rest of the team the changes so more than one person knows how stuff work and what's going on in the code base. And for the rest of the team to give feedback on stuff like how the feature was architected, not to nitpick on indenting.
  • icebraining 9y ago
    A PR is about showing the rest of the team the changes so more than one person knows how stuff work and what's going on in the code base. But that's not really applicable here, right?
• yessql 9y ago
  I can write sort algorithms that are nlog(n) or n^2. Both pass functional tests. I can write code that reinvents the wheel, instead of using the solid library I've never heard of. I can do things in non-idiomatic ways that testing and linting will never catch.
• paradite 9y ago
  - check for best practices - check for whether external or downstream services would be affected (in the absence of complete e2e testing) - check for coding conventions and standards that are not enforceable by linters, such as naming conventions, code structuring, positive/negative testing, effective usage of helper methods - check for typos