3 ms·
Roughly speaking, I think there are 3 aims for code review: 1. Style/consistency, re-use of existing code, utils, etc. 2. Architecture/design, how does this f
by danpalmer 9y ago
Roughly speaking, I think there are 3 aims for code review:
1. Style/consistency, re-use of existing code, utils, etc.
2. Architecture/design, how does this fit into the rest of the codebase, scaling concerns, how will the deploy work, will this have race conditions, etc.
3. Knowledge sharing with other members of the team.
Currently, it looks like this would satisfy half each of 1 and 2, but will miss the (possibly large) amount of context that people working on the project have. To be honest, I don't know how you solve that. How does a reviewer who lacks knowledge about the codebase spot a common pattern and know that another dev abstracted that out into a util a few weeks ago, for example.
I also wonder what could be done to address (3). I've seen the team I work on go from a place where everyone could review everything to a place where I can't review all the code that goes live, and particularly after time off, I can't really catch up. I'd love to see some sort of automated changelog of useful notes on what has changed. I'm not sure if this is possible, but summarising merged PRs, highlighting config changes, showing new utilities that have been added, etc, would be quite valuable.
- lyal 9y agoThanks - excellent notes regarding knowledge sharing. We've kicked around the notion of automatically generating reports from reviews for sharing around the contents of the code review (and underlying changes). Could be fascinating to highlight config/code/approach changes on each pull request. Could actually help velocity across entire teams.
- jbrooksuk 9y agoTo me, code style should not be part of the review process. This should be automated away https://blog.alt-three.com/code-reviews-are-not-about-coding-standards/ https://blog.alt-three.com/code-reviews-are-not-about-coding...
- LrnByTeach 9y ago> 3 aims for code review: > 1. Style/consistency, re-use of existing code, utils, etc. > 2. Architecture/design, how does this fit into the rest of the codebase, scaling concerns, how will the deploy work, will this have race conditions, etc. > 3. Knowledge sharing with other members of the team. > Currently, it looks like this would satisfy half each of 1 and 2 In my opinion, Even a service that address the 1) and 2) add lots of value for so many IT projects (out side of cutting edge Startup companies )
- lamby 9y ago> Even a service that address the 1) and 2) add lots of value for so many IT projects Especially when they currently have no existing code review.