2 ms·
I'm using the Stripe.NET library - but begrudgingly - there's a whole slew of FxCop-compliance issues with the code and some code-smells that I don't like (e.g.
by DaiPlusPlus 9y ago
I'm using the Stripe.NET library - but begrudgingly - there's a whole slew of FxCop-compliance issues with the code and some code-smells that I don't like (e.g. they read the JSON objects into strings, then deserialize the strings - it's more efficient to use the JSON.NET stream-deserializer). My biggest issue is the lack of `using()` statements: objects are not being disposed-of correctly!
(I'd submit a PR with fixes, but I'm short for time).
- nodesocket 9y agoUnderstand about not having the time, but maybe you could create issues (https://github.com/stripe/stripe-dotnet/ https://github.com/stripe/stripe-dotnet/)?