4 ms·

I wonder how elaborate their automated tests are, it is also quite interesting that the provided fix did not introduce any new tests to the codebase for the rep

I wonder how elaborate their automated tests are, it is also quite interesting that the provided fix did not introduce any new tests to the codebase for the reported case.

andrewstuart2 9y ago
Poettering does mention that the tests do not cover LUKS boots, and I would hope they will be adding some in the near future, but I also understand that the priority would be fix first, automated tests second (hopefully), since this is already out in the wild and in need of a fix. Agreed, though, that full-disk encryption is common (and important) enough that it should merit good automated regression testing, especially simple "does it still boot?" tests.
- hobarrera 9y ago
  I was actually amazed they don't test this scenario (I was one of first affected by this bug on all my systems about a week ago). LUKS encryption is probably THE most common setup for newer desktop linux installations, so I was amazed they didn't test this, but just rather plain ol' unencrypted setups.
  - johnny22 9y ago
    Does any popular distro enable it by default?
    - bmn__ 9y ago
      That's the wrong question, it does not matter what the default value in the distro installer partitioning step is. What matters is that LUKS (often labelled as full-disk encryption or similar) is easily available at install time, and consequently enjoys popular adoption and use.