4 ms·
to be fair with that specific example, they changed from a purpose-built function, to a shell call including (albeit extremely simple) text parsing. I'd genera
by thisacctforreal 9y ago
to be fair with that specific example, they changed from a purpose-built function, to a shell call including (albeit extremely simple) text parsing.
I'd generally prefer not to have the git(1) incantation hanging around in an unrelated function.
- conradk 9y agoThe dependency "git-rev" uses a shell-call too, so this PR doesn't change much apart from removing the dependency itself. Here's the original code from the "git-rev" package: https://github.com/tblobaum/git-rev/blob/master/index.js https://github.com/tblobaum/git-rev/blob/master/index.js