4 ms·
The code was reviewed by two other developers and this is the standard procedure for any pull request touching any of our code-base. The mistake that happened h
by 5chdn 9y ago
The code was reviewed by two other developers and this is the standard procedure for any pull request touching any of our code-base. The mistake that happened here, that security-relevant changes were not highlighted accordingly and should have split out in a different pull request which requires more eyes (sample: https://github.com/paritytech/contracts/pull/48 https://github.com/paritytech/contracts/pull/48).
Note, I work for Parity.