4 ms·

The conflation of UI and logic is something I haven't seen since Smarty revolutionized the PHP world.

• bhaak 9y ago
  That seems unnecessary snarky to me. The bug wasn't that the UI and business logic were (or are, I haven't looked at the code) intermingled. But that a refactoring of the UI and a refactoring of the contract code were done in the same step. If they were done separately, the smart contract refactoring wouldn't have slipped through unscrutinized.
  • bluejekyll 9y ago
    It sounds like the code which should be maintained separately, is being maintained in the same repo. This type of issue would be easier to catch with different policies in different repos.
    • nemetroid 9y ago
      If not in a separate repo, then at least properly namespaced away from unrelated code. But no: the contract in question lives in the "Javascript API" subproject, on the path "js/src/contracts/snippets/enhanced-wallet.sol"[0]. [0]: https://github.com/paritytech/parity/blob/master/js/src/contracts/snippets/enhanced-wallet.sol https://github.com/paritytech/parity/blob/master/js/src/cont...