3 ms·
I love my coworkers, they are truly the smartest people I know and I never dreamed of such productive work environment, but these are the practices I found to b
by artpi 9y ago
I love my coworkers, they are truly the smartest people I know and I never dreamed of such productive work environment, but these are the practices I found to be problematic:
- Writing tests in the sam PR introducing a library that is not yet used is waste of time since that library will go through several revisions before fitting in the whole project. In the meanwhile, tests are usually testing interfaces (which is of questionable benefit) and take time to rewrite every time lib interface needs to be adjusted
- „Taking time” to make it „proper” . „Proper” is usually currently hyped opinion and in our case (12 year old product) consistency is always a choice with what we want to be consistent. I am strong believer in coding standards, but I hate consistency with randomness. What I mean is - I’ve seen decision made at random (because sometimes we’re exploring the unknown) and then we force consistency with that decision never reexamining it.
- Designing classes / libraries up front- this is the design process that takes 0 data and turns it into binding decisions. It should be done at the end!
- „If we make code better, the product will be better by extension” - this is pure BS. There is an infinity of nice things you can do with the code that DO NOT trickle down to product experience. Rich Americans getting richer does not trickle down to poor Americans getting richer.
- ‚We are not some code sweat shop where we pump shitty code”. Well, we are not and we CAN make code better AFTER it is working.
- Perfect IS NOT set in stone. There is no 1 perfect solution. There is a myriad of good enough ones, and I love good enough ( it has to be better than „just working" )!