It's frustrating how this thread keeps conflating directness/indirectness with rudeness/kindness. They're different dimensions. Direct/rude: "Wow, X is a stupi

It's frustrating how this thread keeps conflating directness/indirectness with rudeness/kindness. They're different dimensions. Direct/rude: "Wow, X is a stupid way to do Y. X will break case Z, but I guess you're not smart enough to notice things like that. Start over and try not to waste my time again in your next pull request." Direct/kind: "I see you're doing X, but there might be a better way to accomplish Y. For example, X will break case Z. Could you try a different implementation with that in mind?" Indirect/rude: "You must be an idiot to try X. Users who Z will hate you if this change makes it through. Out of all the ways to do Y I don't know why you'd choose this one." Indirect/kind: "I appreciate your effort, but I'm not sure about X. You may not have realized that Z is an important use case and there might be other ways to do Y. It would be nice to think about this some more."