2 ms·
For clarity, I think all three of the quoted comments already show empathy; I just think the first two can retain that empathy while also feeling more direct. (
by JoshTriplett 9y ago
For clarity, I think all three of the quoted comments already show empathy; I just think the first two can retain that empathy while also feeling more direct. (The third, with "Can you take a step back and explain your goal here?", is already fine on that front, and that specific tactic is one I'd highly recommend.)
In the absence of context for the comments in question, I'll have to be somewhat broad in template. For the first, I'd avoid the passive voice like "It would be nice to...", and instead write something like:
"X and Y look good, thanks. For Z, I'd suggest putting this in a data-bind, so that we can more easily switch the view between AB tests in development."
For the second comment:
"I think this will work in many cases, but it might break some limit in the size of $in clauses, which may lead to problem X in the future. I think we can defer that until it becomes a problem, but please keep it in mind if you see a clean way to address it."
For my part, I find that adding rationale also adds more empathy, because it gives the other person the information to reach the same conclusion you did, and it shows trust that you can make non-opaque decisions and still have them hold up. Also helps with mentorship. And taking the time to talk about the things that are good helps when you then need to talk about the things that aren't; I prefer that over the "no news is good news" approach to reviewing.
- mistermann 9y agoAdding rationale (mentorship) is a much more improved approach as it can be the gift that keeps on giving.