It's a good comprehensive list, but considerably biased by the author's research interests. There are lots of good theoretical physicists that don't know much a

It's a good comprehensive list, but considerably biased by the author's research interests. There are lots of good theoretical physicists that don't know much about the specifics of string theory and haven't seen general relativity since the relevant graduate course, it just depends on the field you decide to specialize in. On the math side, aside from a few things very specific to string theory, most of it is useful throughout modern theoretical physics, and it certainly helps to have at least a passing familiarity with all of the subjects listed for general erudition. The list could also be expanded with lots of things on the computational side that aren't immediately useful to string theorists but are used in many other fields. Disclaimer: just a theoretical physics postdoc, YMMV.