3 ms·

I don't think anybody's saying not to do it before merging. (How would anyone even tell?) > A pre commit git hook gets triggered to run the linter[...] Git ho

I don't think anybody's saying not to do it before merging. (How would anyone even tell?) > A pre commit git hook gets triggered to run the linter[...] Git hooks actually need to be set up to work, so this incurs overhead for onboarding.

dav 9y ago
I built a simple system for some of our repos that fails the build if you don't have the shared team git hooks set up properly, and on failure directs the new engineers on how to fix the situation.
- swsieber 9y ago
  And really, one should just set up the hooks automatically when the build script is run, if you really want to reduce friction.
- lomnakkus 9y ago
  A great idea, but this also takes time, albeit once rather than N times. Any chance you could share some of the scripts (etc.)?
yes_or_gnome 9y ago
This is one reason why I find GitHub (especially, Enterprise) so frustrating. I want simple server-side githooks to verify that client-side hooks were used (or, at least a good forgery). I don't want to setup an additional CI environment just to run the most basic SED commands. Nor do I want to make my existing CI environment more complicated by merging disparate validations; unit test validation and commit validations.