4 ms·
You can say that enforcing an 80 character line is outdated, but I often find myself looking at code reviews in GitHub on my smartphone, and it dramatically imp
by dankohn1 9y ago
You can say that enforcing an 80 character line is outdated, but I often find myself looking at code reviews in GitHub on my smartphone, and it dramatically improves readability in that environment.
- dimman 9y agoI haven't said it's outdated though just that I don't always follow it. Desktop Github version seems to show 125 chars (including -+) and on my iphone I'm below 50 char width by default. I just prioritize to have "readable" code in my editor as first prio, second would be sites like Github on desktop and if it works good on a mobile phone that's a plus but not high prio for me. (To be honest though I do actually glance through some Github reviews on my phone, but since it's pretty limited I do find myself thinking that I should get to a computer and do a real review there instead.)
- dankohn1 9y agoI turn my phone to landscape first. And, yes, if any meaningful comments are needed I wait until I'm back at my laptop.