4 ms·
Issues I can understand not responding to but pull requests that fix things and pass tests should be a one-click merge.
by voltagex_ 9y ago
Issues I can understand not responding to but pull requests that fix things and pass tests should be a one-click merge.
- klez 9y agoThat may be dangerous. What if the patch works, passes all tests by contains non-obviously malicious (or simply non-obviously buggy, which no current test catches) code? I prefer maintainers taking a bit more time to review it instead of doing one-click merges. Of course, there's a world between one-click merge and total unresponsiveness, but still.