3 ms·
Sure, the OP may very well have a conflict of interest. At the very least, he has the conflict of interest of wanting to draw attention to his own post. Hanlon'
by btown 9y ago
Sure, the OP may very well have a conflict of interest. At the very least, he has the conflict of interest of wanting to draw attention to his own post. Hanlon's Razor would suggest that the OP simply went overboard in finding criticisms, where only a few would do.
But independent of intent, the logical arguments about trading phenomena make sense, and what's worse, the code smell is very, very real. If you want to see the source for that screenshot, here it is in all its gory detail:
https://github.com/bancorprotocol/contracts/blob/f198f7d66580578ba06730f415d4276bbf6195c2/solidity/contracts/BancorFormula.sol#L221 https://github.com/bancorprotocol/contracts/blob/f198f7d6658...
Oh, they say it's exposed for unit testing! Let's grep the codebase for fixedExpUnsafe... nothing. Oh, and it's in the same file as the business logic; the only test for that file is for the end-to-end logic. "Forget the unit tests, the integration test will catch it." Yeah... Not the type of code I'd bet my business on.