3 ms·
It may be nice, but it certainly is buggy: bool isatty = config->global->isatty; [...] if(!config) return failure;
by Someone 9y ago
It may be nice, but it certainly is buggy:
bool isatty = config->global->isatty;
[...]
if(!config)
return failure;
- jwilk 9y agoFixed: https://github.com/curl/curl/commit/d4cc240c19f84c https://github.com/curl/curl/commit/d4cc240c19f84c
- Someone 9y agoAre you sure you can do without that null pointer check? I would have moved it to before the pointer dereference in the initialization of isatty (if you fear or know some compilers won't accept local declarations after statements in functions, split declaration and assignment of isatty, too)