3 ms·
Refactor code as you read it. If you see a method that doesn't make sense to you, change it. Even if you don't merge your changes, the exercise of trying to sol
by jakeblues 9y ago
Refactor code as you read it. If you see a method that doesn't make sense to you, change it. Even if you don't merge your changes, the exercise of trying to solve the same problem the original engineers were trying to solve is, in my opinion, the fastest and most effective way to get up to speed with a codebase.
- falcolas 9y agoErr, I would advise to absolutely don't do this as a new employee. Ever. If you see a method which doesn't make sense to you, ask about it. Why is it running the way it is? What corner case prompted it? Is there testing which covers it? Only once you're sure that the code really is problematic should you refactor it. Otherwise, you're begging for regressions, new bugs, and conflicts with people who wrote the code in the first place. Understand the impact of codebase you're looking at before you try and change it.