3 ms·
Whenever you put a comment, chances are you should have encapsulated the block there into a reusable block of code.
by EGreg 10y ago
Whenever you put a comment, chances are you should have encapsulated the block there into a reusable block of code.
- eridius 10y agoWhy? You're saying that without any supporting evidence. And frankly, what you're suggesting sounds to me like an unreadable mess. You're going to bloat your code with closures all over the place, simply so you can attach a name to the closure, all to avoid having a simple comment. Naming closures is not a good substitute for comments.
- hoodunit 10y agoNaming closures or functions absolutely is a good substitute for a large class of comments. When you write a comment as a function name, that comment gets maintained when the code changes. It also encourages modularizing your code- often when you write a comment it's a sign that your code is trying to operate conceptually on more than one level and it would be more understandable to separate those levels. I wouldn't say comments are an antipattern but they are a code smell and should be used sparingly and only where the same explanation can't be given through function/variable naming or refactoring.