12 ms·
Everyone's code basically sucks, including yours. The boundary between a beginner and a coding rockstar really isn't very great unless you are getting into the
by ravenstine 10y ago
Everyone's code basically sucks, including yours. The boundary between a beginner and a coding rockstar really isn't very great unless you are getting into the realm of computer sciences, like machine learning. Learn from your seemingly smarter peers, but don't idolize them. Chances are they will leave the company long before you do, and you will figure out that their coding skills aren't all they are cracked up to be, especially if their code is poorly documented. You will soon understand that they were focusing on getting the job done, while you were expending all that effort to be clever. In that sense, they were totally right.
Don't overwork. Seems obvious, though it's not only still prevalent in America, but more important for our field. Working extra hours has rarely benefitted me either in quality of work or in company treatment. Nobody cares that you put in extra hours. In fact, don't expect your boss to care about anything you are doing even if they are generally benevolent.
Your success is mostly dependent on your personality with appearance as a close second. That's not to say you won't have big wins with the projects you work on, but a lousy programmer won't get fired if they are charming and everyone likes them. The more I refined my social skills, as well as my grooming, the more my minor achievements would get overinflated by my peers and the more they would overlook my mistakes. It's just a cruel fact of life, but at least it's something most people can actually address.
- kexari 10y agoTotally agree on the personality and grooming points you made. You need to be good at making people know exactly what you have achieved. Shout about it on slack, fire up google docs and write some brief documentation on a new feature you implemented. Others within the company won't be actively looking at your contributions. They will notice who stands out, who is taking initiative and touching base regularly. Unfortunately this trumps true programming talent in startups - EVEN if you are one of the gods.
- walljm 10y agoI agree. Its also worth noting that the need to publicise your work should not be taken so far that people perceive you as boastful. So there is a balance, but you definitely can't just be quiet all the time.
- sammydavis 10y agoAlso, ask for the new, interesting work, make designs, talk to others about your ideas - don't just show up with a complex multi week/month solution. I've never understood why more people don't ask for the interesting, fun, challenging stuff. I've always done that, and been glad I did.
- groby_b 10y agoIf you believe you're one of the gods, you're likely delusional. If you don't communicate well and hold that belief, you're certainly delusional. Programming talent is useless if you can't communicate. Because your main job as a company grows is to grow the people around you, not cranking out more code. Communication overtakes pure coding skill the moment more than one person works on a project. It's not about "trumping talent", it's about the fact that communication is part of the talents you need.
- tekstar 10y ago> The boundary between a beginner and a coding rockstar really isn't very great unless you are getting into the realm of computer sciences, like machine learning. This is really untrue. On the surface, code might look the same between a beginner and a senior developer, but the decisions underlying the code will be night and day. Beginners will solve the problem of the day directly, with no care for introducing complexity and no willingness to reconsider past decisions.
- hinkley 10y agoIn many fields, it takes a master to make everything look easy. It really seems to be the same with programming. Coming from the other direction, just because it's straightforward to you doesn't mean it's obvious to everybody else. Try to be patient.
- cookiecaper 10y agoMy interpretation is that most of this disagreement is just from ambiguity left by the parent's brevity. Experience certainly shines bright in architectural and design decisions. I think the parent's point is that no one's code should be considered sacrosanct; all of us can make mistakes, and all of us, even the senior guys, will end up writing some ugly hacks just to get something out the door on time. More junior programmers should not be afraid to make a pass at improving something, nor should they try to emulate their peers' styles or behaviors without thinking about and processing them, lest they internalize bad habits. If a junior dev notices an error, they should point it out, instead of assuming the senior developer's code is beyond reproach. They should understand that once they get added to the resident Wizard's project, they're still going to have to deal with the reality of a production application, which means shortcuts, impurities, bugs, and mistakes. The principle of Linus's Law depends on developers who are willing to call out mistakes and at least prompt a discussion about the tradeoffs. This doesn't mean that senior developers won't be much better at writing maintainable code on a macro level. This is especially true because I've found it usually takes until upper-mid-level for developers to really get an appreciation for simplicity and avoidance of technical debt, and to register that you're actually better if you can do more with less. (n.b.: speeding up a computer program is just making it do less)
- robotpony 10y agoI tell my teams this regularly: you'll hate all legacy code you work with, especially your own. This means, in essence, that you always hate your past self. Pushing that hate for legacy code to your own self is important, as it as a good motivation to improve (for us narcissists at least).
- DonbunEf7 10y agoA corollary of your first point is that it is code that is bad, and not your coworkers. Code is complex and nobody really knows how to program. (Proof: If folks did know how to program, then we wouldn't fight over which programming language is the right one; it'd be obvious.) So don't ever blame your coworkers unless they're deliberately malicious; instead, have compassion for them and for yourself as well.
- pmarreck 10y ago> Everyone's code basically sucks, including yours. Which is why I'd say, unit-test your code, or TDD, or something. When you look at that crap months later, your mental model of how it all works has completely eroded, and only the test suite is left to preserve your expectations as they existed back then, preventing you from wasting a lot of time stepping on your own toes while you re-grok the big picture, if you have to make a change. > The boundary between a beginner and a coding rockstar really isn't very great unless you are getting into the realm of computer sciences, like machine learning. I don't agree with this. I didn't spend 20 years learning nothing, as it were.
- hinkley 10y agoYeah, I started using TDD, and now I sweat over my tests instead of my code. Same general quantity of perspiration either way.
- michaelbarton 10y agoI agree with your sentiment. I also think of TDD as a way of trying to overcome confirmation bias. I actively try and write tests that might prove my code has bugs. When they don't fail I feel more confident about what I'm shipping. For me that's the craftsmanship in software development - shipping something I'm proud of.
- dhruvkar 10y agoI'm.just now getting to the point where I'm finding this necessary. Any resources you can point to for a beginner in testing (python)?
- sk1pper 10y agoTDD seems to be mentioned in a lot of responses here. I'm warming up to the idea but frankly not many folks I've come across in my (short, 3 year) career seem to understand tests really, definitely not TDD. So I've been having to learn the hard way. My main thing with TDD right now is - how do I avoid writing tests that are too tightly coupled? I've gotten burned in the past, not even doing TDD, with tests that "know too much" and end up being more hassle than help. Any good resources on TDD and general testing strategy that anyone can recommend?
- flavio81 10y ago> The boundary between a beginner and a coding rockstar really isn't very great I respectfully disagree. My experience says the difference between a beginner and a really good, experience coder, is HUGE, and not only on fields like "machine learning" but in everyday commercial systems. Unless, of course, your platform is something like Java where everybody is crippled to an extreme degree. That is, if you get 400 people on a room, tie their hands and their feet, they most likely dance with the same skill, their dancing experience notwithstanding ...
- rak00n 10y agoAlso it makes a huge difference for the next person who'd work on that codebase to add a new feature. Doing that could be anything between a breeze to a blazing nightmare depending on who wrote those codes earlier.
- ilikerashers 10y agoThe point he was making is that most experienced coders are focused on delivering, regardless of how slick their code could potentially be and eventually all code will suck. You just proved this by picking on Java.
- lliamander 10y agoI think an important piece of advice to take from this (and something that I learned early on) is to favor tools that reward mastery. In this respect Java isn't actually that bad, even if there are better options available. What's worse is the culture of many organizations that happen to use Java.
- ben_jones 10y agoMisapplied Java design patters are the root of all AbstractWordFactoryFactory("evil").
- tkel 10y agoAfter having worked in a legacy javascript codebase, I can say it is very much possible to discern between sucky code and code that is maintainable.
- 103e 10y agovtddtrjeb
- cookiecaper 10y ago>Nobody cares that you put in extra hours. This is all in the presentation. The point of putting in extra hours is not to get more work done, but to appear at least as busy as (but preferably busier than) your peers. Most people can't tell if your work is good or not. They can only tell if it looks like you're working hard, and if they like you/find you personable. For most people, "butt in chair time" becomes the biggest factor in their perception of how hard you're working. Since you're providing good advice about appearance, politics, and popularity, I'm sure you've registered this. We should just clarify for the people who are "4 years in" that "don't overwork" means "don't actually overwork", but do take care to ensure everyone in your office thinks you're a hard worker.
- jonahx 10y ago> The boundary between a beginner and a coding rockstar really isn't very great I'll add to the chorus here and say this is not only untrue, but so untrue as to be absurd. By all means caution against hero worship and remember that even those with exceptional talents are human, but don't misinterpret that lesson to mean there are not vast differences in quality between a beginner and an expert.
- BurningFrog 10y agoOne thing I know for sure is the enormous difference between myself as a beginner and today!
- rickdg 10y agoThat seems like a lesson in corporate culture, not programming. Nothing that you do really matters more than how good you look doing it?