4 ms·
> Github PRs are light years ahead of Gitlab merge requests I would love to know more about your thoughts on this statement ;) in order to get to actionable is
by dimitrieh 9y ago
> Github PRs are light years ahead of Gitlab merge requests
I would love to know more about your thoughts on this statement ;) in order to get to actionable issues on which we can improve!
- Keats 9y agoGithub pros: - Can see new stuff that happened since the last time I was on the PR - Review mode - Faster - Can view rendered file (like .md) without leaving the page - Commits visible on the main tab And for a more subjective one: the gitlab feels extremely crowded and a general lack of polish. Take the right sidebar on a merge request for examples, they are icons since it is hidden by default even in full screen. Hovering on the + shows a Add Todo dialog but hovering over any other icon does nothing. I had to click to see what the watch and stopwatch were. In general, I wasn't able to guess what any of the icons were, except for the labels icon. On the other hand, Github doesn't use icons: just a bunch of text which is imo nicer in terms of design and more user friendly.
- dimitrieh 9y agothanks! Will keep these things in mind!
- cmatija 9y agoHiya, Thanks for leaving some feedback. * Speed GNOME is looking to self-host their own GitLab CE instance. We understand that GitLab.com might have some performance issues. This is specific to our hosted GitLab instance due to its scale. A self-hosted instance on a much smaller scale is much much faster. Also, we're always looking to improve GitLab performance - check out issues labeled "performance" in the GitLab CE repo [1] as well as issues in the infrastructure repo which are about .com specifically [2] * Commits visible on the main tab A list of commits is just a click away in the MR view, in the "Commits" tab. Also commits that are added are also displayed in the main tab. * Can see new stuff that happened The main MR tab lists the actions that happened related to it in a chronological order, from first to last. You can always look at that and see any new MR changes * Sidebar The sidebar is expanded by default on larger screen sizes and collapsed on smaller ones to preserve screen real estate for the MR itself. I opened an issue about the icons themselves, see [3] * View rendered files in MR We have renderers for all kinds of files. But in a MR, we diff the MD source files. If we rendered them, diffing them would be almost impossible. I opened an issue about having toggle-able rendering in the changes tab in MRs. Feel free to chime in in [4] * Review mode Could you explain this in a bit more detail? Maybe we could open a feature proposal for this functionality. Hopefully I addressed all your concerns, feel free to add anything or dive into any of the issues, or even contact me personally. [1] - https://gitlab.com/gitlab-org/gitlab-ce/issues?scope=all&utf8=&state=opened&label_name[]=performance https://gitlab.com/gitlab-org/gitlab-ce/issues?scope=all&utf... [2] - https://gitlab.com/gitlab-com/infrastructure/issues?scope=all&utf8=&state=opened&label_name[]=performance https://gitlab.com/gitlab-com/infrastructure/issues?scope=al... [3] - https://gitlab.com/gitlab-org/gitlab-ce/issues/32413 https://gitlab.com/gitlab-org/gitlab-ce/issues/32413 [4] - https://gitlab.com/gitlab-org/gitlab-ce/issues/32414 https://gitlab.com/gitlab-org/gitlab-ce/issues/32414