5 ms·

I'm really sorry to hear about the crappy experience you've had with GitLab. If you'd like to detail some more complaints, I'd love to hear them and open some i

I'm really sorry to hear about the crappy experience you've had with GitLab. If you'd like to detail some more complaints, I'd love to hear them and open some issues about these things. Feel free to shoot me an email (located in my profile) or reply here. Either way, thanks for the feedback you've provided here. As far as the frequent upgrades go, we've been using .com as a way of dogfooding GitLab at scale. Sometimes this goes well and other times it doesn't. We're actively working to improve this process so that downtime and breaking changes are less frequent. The end goal is to eradicate both issues so that upgrades are seamless.

ghrifter 9y ago
One issue I encounter often-ish is that when I'm on a gitlab page then hit the back button in the browser - I get a bunch of JSON spit onto the page instead of an actual HTML document. Whats up with that?
- Perihelion 9y ago
  I've actually experienced this exact thing. Usually a refresh fixes it for me so I never gave it too much thought. I'm not sure what causes it exactly but I'll follow up with the team about it. It usually happens to me on merge requests -- do you notice it on specific pages at all?
  - sytse 9y ago
    I think this is due to Rails Turbolinks. Since we're deprecating Turbolinks https://about.gitlab.com/2017/02/06/vue-big-plan/ https://about.gitlab.com/2017/02/06/vue-big-plan/ I think this problem should go away.
    - sytse 9y ago
      It seems to be caused by and fixed in https://gitlab.com/gitlab-org/gitlab-ce/issues/28909 https://gitlab.com/gitlab-org/gitlab-ce/issues/28909
  - jcrben 9y ago
    > Usually a refresh fixes it for me so I never gave it too much thought. As someone who hacks on a SaaS with a sprawling feature set which ships often, I understand where you're coming from. But I would recommend giving things like that some thought.
- flukus 9y ago
  > Whats up with that? A sign of the future. As browser march headlong into being app platforms instead of browsers expect the back button to disappear entirely.
  - nine_k 9y ago
    What? I suppose you saw what Android looks like?
    - oneeyedpigeon 9y ago
      I'm still not really sure, when I press the back button in Android, whether I'm going to stay in the same app, go to a different app, or close the app; all three behaviours are common.
      - flukus 9y ago
        I think they've all been standard behaviors at various times too. There's a fourth option too, will it close the slide out menu or not?
  - chc 9y ago
    People have been saying that since like 2005. Web apps may not be your personal preference, but they're not the apocalypse either.
    - flukus 9y ago
      In 2005 SaaS companies weren't behind the leading browsers.
- wincent 9y ago
  Most likely needs a Vary header (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Vary https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Va...) set to "X-Requested-With"; otherwise the browser will use whatever it has cached for the last request when you hit the back button (and if it was an Ajax request, that's probably going to mean a bunch of JSON).
  - pas 9y ago
    Huh? Do XHR requests go on the navigation history stack? WTF? Why? And why would any site use the same URIs for API endpoints and frontend/view navigation places? And in that case should the Content-Type (or Accepts) be the main factor?
    - untog 9y ago
      No, I think the OP is suggesting that the same URL will have been requested in both JSON and HTML formats, and the browser cache is not differentiating between them.
      - pas 9y ago
        Yes, I understand that, but that seems crazy on multiple levels. Why the X-Requested-With should be in Vary when the same client did the request? (Yes, I see, Ajax libs populate this field, whereas usual browser navigation doesn't. Makes no sense.) Why is that resource in cache anyhow, when it should be Cache-Control: no-cache (or at least must-revalidate, but it probably is, but of course that again means that the cache returns the JSON after getting the 304 from the backend, because it doesn't differentiate between responses with different Content-Type)? It seems to me that the X-Requested-With is again a hack on top of "representational state transfer", because it was easier than trying to use Content-Type.
    - glitchdout 9y ago
      > Why would any site use the same URIs for API endpoints and frontend/view navigation places? Simplicity. Ruby on Rails facilitates that approach, for example. > And in that case should the Content-Type (or Accepts) be the main factor? Content-Type, yup! Unfortunately Chrome and IE 10 (not sure about Edge) disagree on that. Without the Vary header, the back button leads to rendering what the server last returned, without taking the Content-Type into account - which is completely nonsensical in my opinion. Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=94369 https://bugs.chromium.org/p/chromium/issues/detail?id=94369 Repo and page that demonstrate the issue: https://github.com/guilhermesimoes/chrome-bug https://github.com/guilhermesimoes/chrome-bug This has been going on since at least 2011 so it seems nobody cares. I honestly do not understand why that Vary header is necessary. Firefox doesn't seem to need it to render pages from its cache correctly.
notatoad 9y ago
>shoot me an email (located in my profile) no it isn't?
- desdiv 9y ago
  I tried to find her email on her keybase page but it isn't there. Ironically her Github page is listed, but her Gitlab page isn't.
- Perihelion 9y ago
  Hmm, not sure what happened. It was there, now it's not. It's amanda@gitlab.com -- sorry about that.
  - Shamiq 9y ago
    The email address field in your user form isn't public. you need to add it to text in your description.
    - Perihelion 9y ago
      Yeah, it was there (along with a note on how to get free stickers) but now it's gone. Keybase stuff is still there though. Random.
arctangent 9y ago
So much hate in this thread! @Perihelion: Allow me to be the one who says "thanks for your efforts" and "keep up the good work". My team are using GitLab to manage development and we're happy with how it's going so far.
- Perihelion 9y ago
  Thanks so much for your kind words! We're always trying to improve, so even though some of the comments are negative, it's still good to hear about pain points so we can fix them.

ghrifter 9y ago

One issue I encounter often-ish is that when I'm on a gitlab page then hit the back button in the browser - I get a bunch of JSON spit onto the page instead of an actual HTML document. Whats up with that?

Perihelion 9y ago
I've actually experienced this exact thing. Usually a refresh fixes it for me so I never gave it too much thought. I'm not sure what causes it exactly but I'll follow up with the team about it. It usually happens to me on merge requests -- do you notice it on specific pages at all?
- sytse 9y ago
  I think this is due to Rails Turbolinks. Since we're deprecating Turbolinks https://about.gitlab.com/2017/02/06/vue-big-plan/ https://about.gitlab.com/2017/02/06/vue-big-plan/ I think this problem should go away.
  - sytse 9y ago
    It seems to be caused by and fixed in https://gitlab.com/gitlab-org/gitlab-ce/issues/28909 https://gitlab.com/gitlab-org/gitlab-ce/issues/28909
- jcrben 9y ago
  > Usually a refresh fixes it for me so I never gave it too much thought. As someone who hacks on a SaaS with a sprawling feature set which ships often, I understand where you're coming from. But I would recommend giving things like that some thought.
flukus 9y ago
> Whats up with that? A sign of the future. As browser march headlong into being app platforms instead of browsers expect the back button to disappear entirely.
- nine_k 9y ago
  What? I suppose you saw what Android looks like?
  - oneeyedpigeon 9y ago
    I'm still not really sure, when I press the back button in Android, whether I'm going to stay in the same app, go to a different app, or close the app; all three behaviours are common.
    - flukus 9y ago
      I think they've all been standard behaviors at various times too. There's a fourth option too, will it close the slide out menu or not?
- chc 9y ago
  People have been saying that since like 2005. Web apps may not be your personal preference, but they're not the apocalypse either.
  - flukus 9y ago
    In 2005 SaaS companies weren't behind the leading browsers.
wincent 9y ago
Most likely needs a Vary header (https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Vary https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Va...) set to "X-Requested-With"; otherwise the browser will use whatever it has cached for the last request when you hit the back button (and if it was an Ajax request, that's probably going to mean a bunch of JSON).
- pas 9y ago
  Huh? Do XHR requests go on the navigation history stack? WTF? Why? And why would any site use the same URIs for API endpoints and frontend/view navigation places? And in that case should the Content-Type (or Accepts) be the main factor?
  - untog 9y ago
    No, I think the OP is suggesting that the same URL will have been requested in both JSON and HTML formats, and the browser cache is not differentiating between them.
    - pas 9y ago
      Yes, I understand that, but that seems crazy on multiple levels. Why the X-Requested-With should be in Vary when the same client did the request? (Yes, I see, Ajax libs populate this field, whereas usual browser navigation doesn't. Makes no sense.) Why is that resource in cache anyhow, when it should be Cache-Control: no-cache (or at least must-revalidate, but it probably is, but of course that again means that the cache returns the JSON after getting the 304 from the backend, because it doesn't differentiate between responses with different Content-Type)? It seems to me that the X-Requested-With is again a hack on top of "representational state transfer", because it was easier than trying to use Content-Type.
  - glitchdout 9y ago
    > Why would any site use the same URIs for API endpoints and frontend/view navigation places? Simplicity. Ruby on Rails facilitates that approach, for example. > And in that case should the Content-Type (or Accepts) be the main factor? Content-Type, yup! Unfortunately Chrome and IE 10 (not sure about Edge) disagree on that. Without the Vary header, the back button leads to rendering what the server last returned, without taking the Content-Type into account - which is completely nonsensical in my opinion. Chromium bug: https://bugs.chromium.org/p/chromium/issues/detail?id=94369 https://bugs.chromium.org/p/chromium/issues/detail?id=94369 Repo and page that demonstrate the issue: https://github.com/guilhermesimoes/chrome-bug https://github.com/guilhermesimoes/chrome-bug This has been going on since at least 2011 so it seems nobody cares. I honestly do not understand why that Vary header is necessary. Firefox doesn't seem to need it to render pages from its cache correctly.

notatoad 9y ago

>shoot me an email (located in my profile) no it isn't?

desdiv 9y ago
I tried to find her email on her keybase page but it isn't there. Ironically her Github page is listed, but her Gitlab page isn't.
Perihelion 9y ago
Hmm, not sure what happened. It was there, now it's not. It's amanda@gitlab.com -- sorry about that.
- Shamiq 9y ago
  The email address field in your user form isn't public. you need to add it to text in your description.
  - Perihelion 9y ago
    Yeah, it was there (along with a note on how to get free stickers) but now it's gone. Keybase stuff is still there though. Random.

arctangent 9y ago

So much hate in this thread! @Perihelion: Allow me to be the one who says "thanks for your efforts" and "keep up the good work". My team are using GitLab to manage development and we're happy with how it's going so far.

Perihelion 9y ago
Thanks so much for your kind words! We're always trying to improve, so even though some of the comments are negative, it's still good to hear about pain points so we can fix them.