4 ms·
That kind of dogma does seem a bit silly, but why wouldn't you split the commits into separate pull requests instead of squasing, e.g. PR1: "refactor code to al
by Androider 9y ago
That kind of dogma does seem a bit silly, but why wouldn't you split the commits into separate pull requests instead of squasing, e.g. PR1: "refactor code to allow thing X to be pluggable", PR2: "implement new alternative for thing X" etc. The discussion around PR1 can then focus on just the plugin interface for example.
- Macha 9y agoEach PR needs its own branch build and then a CI build after merging. So there'd be lots of downtime just screwing around with CI builds and resolving interim merge conflicts.