3 ms·
I think your JSON keys are verbose. Command to run should be just called command. And trigger rule can be just trigger no? Maybe personal preference.
by ziikutv 9y ago
I think your JSON keys are verbose.
Command to run should be just called command. And trigger rule can be just trigger no?
Maybe personal preference.
- lekker 9y agoThey are a little verbose, though it is likely not to cause problems here. I suppose that it may slow things down a very tiny bit. The author could possibly have been trying to future-proof it with a bit more verbosity in the face of allowing for other keys (execute-mode, execute-permissions) etc.
- adnanh 9y agoYes. I believe that it's better to be verbose rather than obscure. I'm of a belief that it's easier for someone to understand what was the original intention of the "pass-arguments-to-command" rather than "arguments" keyword. The verbosity shouldn't affect performance significantly.
- ziikutv 9y ago"pass-arguments-to-command" vs "commandArguments" Verbosity is sometimes good but in the context of this.. Where all you are doing is giving commands, giving them arguments... there are not so many things here that can lead to confusion. If you had multiple arg fields I understand. Again, preference :)