3 ms·
Interesting that the author highlights CodeClimate's "support" of TODO comments via the FixMe engine. The problem is that the TODOs get flagged as failures in
by jsdalton 9y ago
Interesting that the author highlights CodeClimate's "support" of TODO comments via the FixMe engine.
The problem is that the TODOs get flagged as failures in the context of a pull request and require a manual override. The overall attitude in the tooling is TODOs as a code smell or problem vs. a solution.
Maybe this is not a big deal (since you can interpret the information however you choose) but it creates cultural resistance to embracing TODOs. We've recently started dabbling with TODOs again on my team but I still haven't overcome a bit of guilt I feel, like maybe "I'm doing it wrong" -- even though I think TODOs are a perfect fit for highlighting small tidbits of technical debt as the author describes here.
- brynary 9y ago(Founder of Code Climate here.) This is really good feedback, which we are addressing. We're going to change things up so that by default TODO issues are emitted as "Info" severity instead of "Minor", and we are going to change our PR integration so it does not fail PRs on "Info" issues. As an aside, on Tuesday we launched a Grep engine, which is much more powerful than FIXME: https://codeclimate.com/changelog/58ecfa297705a149790008b2 https://codeclimate.com/changelog/58ecfa297705a149790008b2 It allows full customization of the emitted issues.