4 ms·
Yikes, yeah, this is bad. I only went through the readme, I didn't look at the source, and just...no. NULL? no. nullptr, please. And, as you've said, const char
by hermitdev 9y ago
Yikes, yeah, this is bad. I only went through the readme, I didn't look at the source, and just...no. NULL? no. nullptr, please. And, as you've said, const char* as strings? again, no. I know GLS isn't terribly old, but something like string_view is in order. Arguments as undecorated pointers...no. Are they in or out? optional? C++ has semantics to indicate these things (even without GLS).
- andrewchambers 9y agoThis thread of conversation is unproductive. Could you link me to both of your respective github accounts so I can nitpick without any stake or contribution in your projects?
- milesrout 9y agoIt's not unproductive. The project was linked, and code quality is relevant.
- kazinator 9y agoYou may criticize anything I've ever written that you can find. As a software developer, that's my daily assumption. The increasing adoption of code review tools like Gerrit is one of the best things that has been happening in recent years. No piece of code I've written in the past few years on the job has gone into the stream without the approval of several people. Frequently, it had to be revised. More than once.
- hermitdev 9y agoNo, because I'm bound by contract, cannot disclose my source, and I'm under NDA. That said, my comments are not unreasonabe or overly critical for C++11 or newer code. Quite honestly, if I desired to, there's more I could probably find issue with in even that small of a code sample.