5 ms·
Should not come as a surprise... https://what.thedailywtf.com/topic/15687/code-review-malediction https://what.thedailywtf.com/topic/15687/code-review-maledic.
by thomask0 9y ago
Should not come as a surprise...
https://what.thedailywtf.com/topic/15687/code-review-malediction https://what.thedailywtf.com/topic/15687/code-review-maledic...
https://what.thedailywtf.com/topic/15001/enlightened https://what.thedailywtf.com/topic/15001/enlightened
- coldtea 9y ago> https://what.thedailywtf.com/topic/15001/enlightened https://what.thedailywtf.com/topic/15001/enlightened Actually it's the author of the rant that comes of as totally uninformed and with unwarranted snark to boot. https://what.thedailywtf.com/topic/15001/enlightened/242 https://what.thedailywtf.com/topic/15001/enlightened/242
- phpnode 9y agoThe responses in that thread give me a headache, has the daily wtf forum always been such a wasteland? One of the replies is "someone posted your software to the daily wtf so there MUST be a problem with your software, you should just accept it and here's how you should respond". Maddening
- coldtea 9y agoYes. And they even scold the author of the software for responding in an emotional tone, while the whole "wtf" rant was full of personal attacks (and misunderstanding C programming, not bothering with facts etc). And thusly, a website originally created for people to point to actual coding WTFs by incompetent programmers is running posts by incompetent users, voted by other incompetent users.
- tigershark 9y agoSeriously? The EFL author flatly denied to have "bitch" in the error message, posting even the grep results, while silently changing the error message from "bitch" to "complain" hoping that no one would notice it. Obviously git history doesn't lie like him. And he was the one that wrote that error message. In the meantime he started attacking the author of the post on that forum with meaningless arguments. And you have the courage to say that the incompetence is in the forum users rather than in such person that is so full of sh*t to just outrightly lie in front of everyone?
- graton 9y agoNot when I read the replies to that reply. @Carsten_Haitzler said: as for the "you bitch" comment. that does not appear anywhere inside efl at asll. i can only assume you are full of bullshit here as with a lot of the prior "facts" you have disclosed, as a grep through our codebase for efl and elementary shows no such string: core/efl.git - EFL core libraries evas - change error out from bitch to complain - cosmetic changeHEADmaster committer Carsten Haitzler (Rasterman) raster@rasterman.com 2015-03-11 12:59:01 (GMT) F#*k off.
- lfowles 9y agoA little bit more context I had to go look up: the response is also dated 11 Mar 2015
- coldtea 9y agoAnd as the author of the code writes 2-4 times, he looked for the literally mentioned quote and didn't find it -- he even posted the grep results. He only found that it was "bitch" (single word) later from a later corrected comment and fixed it (out in the open, in the the public code repository in any way). In any case, again, not technical, not a WTF, and not pertaining to the actual code/implementation.
- int_19h 9y agoThe author of the code is the one who added that word to the code in the first place. You'd think he might remember that, even if the wording of the complaint was off. https://git.enlightenment.org/legacy/evas.git/commit/src/lib/canvas/evas_stack.c?id=e928a2e8f6e975787eb3b884c852b0d4ef123e57 https://git.enlightenment.org/legacy/evas.git/commit/src/lib... https://git.enlightenment.org/legacy/evas.git/commit/src/lib/canvas/evas_stack.c?id=9c3620ce13b372a12100929e76c3bde6b39a8d8c https://git.enlightenment.org/legacy/evas.git/commit/src/lib... If he does not, that invites the question of how many similar error messages are there in the code. Note that this is something that actually gets printed to stdout - in other words, if there's a bug in your app (or EFL, for that matter), your end user might see that message. I would dare say that's a pretty big WTF.
- phlakaton 9y agoAs bad as the author comes off in that exchange, Mr. Haitzler comes off worse. Nobody should respond to their customers like that, least of all in a public forum, regardless of the provocation.
- phpnode 9y agoEFL is open source software, BSD licenced. The original author of the comment is not a customer. It's some uninformed person trashing the good work someone has made available to them for free. This attitude makes me want to stop writing open source, it's disgusting to see.
- phlakaton 9y agoI understand you're upset. But does that make Mr. Haitzler's response OK in your book?
- int_19h 9y agoIf even one third of what the original author was complaining is true (and judging by the response, it's way more than that), I don't see how EFL can be called "good work" in good conscience. Bad code and bad design don't get a free pass on account of being open source.
- phpnode 9y ago
- int_19h 9y agoThat response has plenty of WTFs of its own, e.g.: > efl checks object validity by looking at the first 4 bytes of the memory of the object. in here is a "magic number" that indicates both type and that the object isn't freed or garbage memory.