5 ms·

Original author here. Feel free to ask anything.

ben_jones 10y ago
I checked out twoemproxy because it seemed interesting and noticed a few things: * the last code commit was 8 months ago (and was very minor) * there are 120 open issues * it's written in C Now this is far from abandaomware (imo), but it still seemed like a risky dependency to lean on. Have you guys moved past it already? Any thoughts on the cost-benefit analysis there or alternative solutions? Note: I mention C like a detriment because I myself cannot write production C and therefore would think twice to using a library/service I myself could not fork (and probably many other devs).
- andygrunwald 10y ago
  twemproxy is not the best piece of software when it comes to maintenance of code quality. But it works reliable. We are still using twemproxy and we are maintaining our own fork of it. This fork often has changes from us, like bugfixes or introducing new redis commands that are not supported yet. Every bug we fix we apply this as a PR. A few PRs from the repository we have cherry-picked internally and deployed. But we have also a few issues with it like this one here: https://github.com/twitter/twemproxy/issues/442 https://github.com/twitter/twemproxy/issues/442 or live reconfiguration would be a nice feature. Think about it if you really need this, because it is not only fun. A few pain points: * Deployments of new configs and restarting twemproxy on your server farm * New redis version with new commands? Extend twemproxy for those command support I don't now any _real_ alternative to it, right now. I know from https://github.com/Netflix/dynomite https://github.com/Netflix/dynomite which is a twemproxy fork. When we had only memcached and no redis (we are using both with twemproxy), then we would try https://github.com/facebook/mcrouter https://github.com/facebook/mcrouter from facebook. But it is specialized on memcached. If you come up with an alternative, please let me know.
  - ben_jones 10y ago
    Thanks for the response. Sorry no alternative, but a generic database proxy in golang would be a great weekend hack I might try sometime.
    - andygrunwald 10y ago
      https://github.com/eleme/corvus https://github.com/eleme/corvus This might be an option. Someone tweeted me this. Didnt tested this yet
  - maxmatteo 10y ago
    give corvus a try..might fit your use case: https://github.com/eleme/corvus https://github.com/eleme/corvus
pdog 10y ago
Have you met the Trivago guy?
- andygrunwald 10y ago
  Not yet. Sadly.
frik 10y ago
"Proper monitoring and alerting" do you mean the Redis software watchdog? As a bit above you mention running it with flag =0 is generally not a good idea, and propose =500. Do you use it or something else for Redis production server monitoring? something with little impact on performance.

I checked out twoemproxy because it seemed interesting and noticed a few things: * the last code commit was 8 months ago (and was very minor) * there are 120 open issues * it's written in C Now this is far from abandaomware (imo), but it still seemed like a risky dependency to lean on. Have you guys moved past it already? Any thoughts on the cost-benefit analysis there or alternative solutions? Note: I mention C like a detriment because I myself cannot write production C and therefore would think twice to using a library/service I myself could not fork (and probably many other devs).

andygrunwald 10y ago
twemproxy is not the best piece of software when it comes to maintenance of code quality. But it works reliable. We are still using twemproxy and we are maintaining our own fork of it. This fork often has changes from us, like bugfixes or introducing new redis commands that are not supported yet. Every bug we fix we apply this as a PR. A few PRs from the repository we have cherry-picked internally and deployed. But we have also a few issues with it like this one here: https://github.com/twitter/twemproxy/issues/442 https://github.com/twitter/twemproxy/issues/442 or live reconfiguration would be a nice feature. Think about it if you really need this, because it is not only fun. A few pain points: * Deployments of new configs and restarting twemproxy on your server farm * New redis version with new commands? Extend twemproxy for those command support I don't now any _real_ alternative to it, right now. I know from https://github.com/Netflix/dynomite https://github.com/Netflix/dynomite which is a twemproxy fork. When we had only memcached and no redis (we are using both with twemproxy), then we would try https://github.com/facebook/mcrouter https://github.com/facebook/mcrouter from facebook. But it is specialized on memcached. If you come up with an alternative, please let me know.
- ben_jones 10y ago
  Thanks for the response. Sorry no alternative, but a generic database proxy in golang would be a great weekend hack I might try sometime.
  - andygrunwald 10y ago
    https://github.com/eleme/corvus https://github.com/eleme/corvus This might be an option. Someone tweeted me this. Didnt tested this yet
- maxmatteo 10y ago
  give corvus a try..might fit your use case: https://github.com/eleme/corvus https://github.com/eleme/corvus

pdog 10y ago

Have you met the Trivago guy?

andygrunwald 10y ago
Not yet. Sadly.

frik 10y ago

"Proper monitoring and alerting" do you mean the Redis software watchdog? As a bit above you mention running it with flag =0 is generally not a good idea, and propose =500. Do you use it or something else for Redis production server monitoring? something with little impact on performance.