3 ms·
And its fixed already in https://anonscm.debian.org/cgit/pkg-ruby-extras/diaspora-installer.git/commit/?id=7071a253e8404e41e7767b4330899a2da045731c https://anon
by octo_t 10y ago
And its fixed already in https://anonscm.debian.org/cgit/pkg-ruby-extras/diaspora-installer.git/commit/?id=7071a253e8404e41e7767b4330899a2da045731c https://anonscm.debian.org/cgit/pkg-ruby-extras/diaspora-ins...
- megous 10y agoWell, I hope, no user has space at the end of his homedir.
- louiz 10y agoYou hope.
- avian 10y agoThis is not a particularly good fix. It lacks "set -u" which is the first line of defense for this kind of bugs, much more robust than the "if [ -d ...". Command lines lack proper shell quoting. If $diaspora_home ends up with a trailing space somehow, this will again end in a disaster. I don't see the point of adding a "test -e". It seems "rm -rf /var/cache/diaspora /var/log/diaspora" got lost, so these directories are no longer cleaned up after uninstall.
- zeveb 10y agoWell, feel free to submit a patch with an explanation: you'll improve the situation, and others will learn from it!