4 ms·

With the focus on performance, is there any chance we could get pagination on the deploy keys page? Our company is self hosting the CE version and we currently

With the focus on performance, is there any chance we could get pagination on the deploy keys page? Our company is self hosting the CE version and we currently have 339 deployment keys. Every time we need to load the deployment keys page, it takes upwards of 20s. We could probably organize things differently and cut that down, but that would be a significant restructure and time investment for what would essentially be a band-aid. I (and others) have requested it before, but was told it was too low of a priority and it wouldn't be worked on.

connorshea 10y ago
I can't find an issue for this specifically, could you open one so we can get it tracked? https://gitlab.com/gitlab-org/gitlab-ce/issues https://gitlab.com/gitlab-org/gitlab-ce/issues
- apocalyptic0n3 10y ago
  The previous suggestions were done on the old suggestion site and I cannot find a link to that site anymore; it's been a while since I have personally brought it up but noticed all the mentions of performance improvements and, combined with our ever-growing list of keys, it felt like something to bring up again. @zegerjan made a ticket for it, but it's already been closed by Stan because it is being tracked by some general performance ticket. https://gitlab.com/gitlab-org/gitlab-ce/issues/29861 https://gitlab.com/gitlab-org/gitlab-ce/issues/29861
zegerjan 10y ago
I've opened an issue, as I couldn't find another. https://gitlab.com/gitlab-org/gitlab-ce/issues/29861 https://gitlab.com/gitlab-org/gitlab-ce/issues/29861 If we have it profiled we can give it the right priority.
flavor8 10y ago
Pagination on the list of commits in a PR would be awesome also. Oftentimes a week of work that's bundled in our develop->master RC merge will have more than 100 commits. Gitlab _only_ displays 100, and doesn't let you see the rest; since I like to skim down the commit messages to make release notes for the RC, this is pretty inconvenient.
mydigitalself 10y ago
I'm afraid it gets a little worse. In an attempt to simplify some of the settings pages, deploy keys were moved onto the repository settings page. https://gitlab.com/gitlab-org/gitlab-ce/issues/29667 https://gitlab.com/gitlab-org/gitlab-ce/issues/29667 We need to do something about this very soon, so please keep an eye on that issue. We're going to be doing some more work on settings pages, hopefully in 9.2 and make them a lot better. https://gitlab.com/gitlab-org/gitlab-ce/issues/28451 https://gitlab.com/gitlab-org/gitlab-ce/issues/28451
- apocalyptic0n3 10y ago
  So they are on the main Project Settings page as of 9.0? If that's the case, we will avoid upgrading until that is changed because that page will become fairly unusable in our case, both in terms of speed and general UX because our Deploy Keys page is currently 20,777px tall. That is a lot of scrolling to have to deal with. I will subscribe to those issues and hopefully it will improve. As of now, though, that is a complete non-starter for us.
  - mydigitalself 10y ago
    No not the main project settings page. Settings -> Repository and it's right at the bottom, so no more scrolling than you are used to.

connorshea 10y ago

I can't find an issue for this specifically, could you open one so we can get it tracked? https://gitlab.com/gitlab-org/gitlab-ce/issues https://gitlab.com/gitlab-org/gitlab-ce/issues

apocalyptic0n3 10y ago
The previous suggestions were done on the old suggestion site and I cannot find a link to that site anymore; it's been a while since I have personally brought it up but noticed all the mentions of performance improvements and, combined with our ever-growing list of keys, it felt like something to bring up again. @zegerjan made a ticket for it, but it's already been closed by Stan because it is being tracked by some general performance ticket. https://gitlab.com/gitlab-org/gitlab-ce/issues/29861 https://gitlab.com/gitlab-org/gitlab-ce/issues/29861

zegerjan 10y ago

I've opened an issue, as I couldn't find another. https://gitlab.com/gitlab-org/gitlab-ce/issues/29861 https://gitlab.com/gitlab-org/gitlab-ce/issues/29861 If we have it profiled we can give it the right priority.

flavor8 10y ago

Pagination on the list of commits in a PR would be awesome also. Oftentimes a week of work that's bundled in our develop->master RC merge will have more than 100 commits. Gitlab _only_ displays 100, and doesn't let you see the rest; since I like to skim down the commit messages to make release notes for the RC, this is pretty inconvenient.

mydigitalself 10y ago

I'm afraid it gets a little worse. In an attempt to simplify some of the settings pages, deploy keys were moved onto the repository settings page. https://gitlab.com/gitlab-org/gitlab-ce/issues/29667 https://gitlab.com/gitlab-org/gitlab-ce/issues/29667 We need to do something about this very soon, so please keep an eye on that issue. We're going to be doing some more work on settings pages, hopefully in 9.2 and make them a lot better. https://gitlab.com/gitlab-org/gitlab-ce/issues/28451 https://gitlab.com/gitlab-org/gitlab-ce/issues/28451

apocalyptic0n3 10y ago
So they are on the main Project Settings page as of 9.0? If that's the case, we will avoid upgrading until that is changed because that page will become fairly unusable in our case, both in terms of speed and general UX because our Deploy Keys page is currently 20,777px tall. That is a lot of scrolling to have to deal with. I will subscribe to those issues and hopefully it will improve. As of now, though, that is a complete non-starter for us.
- mydigitalself 10y ago
  No not the main project settings page. Settings -> Repository and it's right at the bottom, so no more scrolling than you are used to.