3 ms·
It's an office politics issue. Here we have little issue with it, but I worked in a place that didn't like handling lots of "clean up" commits. The main issue i
by Jtsummers 10y ago
It's an office politics issue. Here we have little issue with it, but I worked in a place that didn't like handling lots of "clean up" commits. The main issue is (working in embedded avionics systems) code changes have to be peer reviewed and qualified. So I've tried to make sure my changes are part of some new or existing PR. I can't do it willy-nilly or I'll be asked, "Why did foo.c:145-150 change?" If it's not part of a PR I can't justify it. So when I stumble on problems, I put them in JIRA. Even if the "problem" is: 200 lines of code without a single comment, all variables have names like XYZ12, XYZ13. It may technically work, but no one knows why and, fortunately, falls afoul of our coding guidelines. I may not be able to work it today, but it's in the system and can be worked at some point when priorities align better.