2 ms·
To me, three or four (or sixteen) hours on 2000 lines of code seems like a good business investment because: 1. A bug can easily consume that many staff hours
by brudgers 10y ago
To me, three or four (or sixteen) hours on 2000 lines of code seems like a good business investment because:
1. A bug can easily consume that many staff hours and create orders of magnitude more losses than the cost of the staff time...and that's just if it is a bug rather than a vulnerability.
2. The reviewer learns the existing code base.
3. The reviewer learns the new code.
4. Peer review is part and parcel of sound engineering practice.
To me, 2000 lines sounds like a large change set and reducing the size and scope of the change set and increasing the frequency of changes might help and is consistent with current industry trends toward process improvement.
My random internet advice is to reframe 'looks good' as evidence that the process of code review is doing what is supposed to do. Not that I particularly like sports analogies, but the sign of a good team defense is what doesn't happen. One of the things that doesn't happen is 'its your fault not mine' when something bad happens.
Good luck.