3 ms·
I really dislike writing comments like this one and I almost never do, but... this is terrible. It's an amateur project at best that's just a big if/else loop[1
by orf 10y ago
I really dislike writing comments like this one and I almost never do, but... this is terrible. It's an amateur project at best that's just a big if/else loop[1] with some very poorly coded[2][3][4] implementations of things.
I get that it might be a cool learning exercise, but if you're in the terminal already what is the value of typing "what time is it" instead of 'date' or "search for a string in file" instead of 'grep'?
1. https://github.com/sukeesh/Jarvis/blob/master/main.py#L20-L83 https://github.com/sukeesh/Jarvis/blob/master/main.py#L20-L8...
2. https://github.com/sukeesh/Jarvis/blob/master/evaluator.py#L10 https://github.com/sukeesh/Jarvis/blob/master/evaluator.py#L...
3. https://github.com/sukeesh/Jarvis/blob/master/picshow.py#L12 https://github.com/sukeesh/Jarvis/blob/master/picshow.py#L12
4. https://github.com/sukeesh/Jarvis/blob/master/todo.py#L38-L78 https://github.com/sukeesh/Jarvis/blob/master/todo.py#L38-L7...
- deleted 10y ago[deleted]
- cocktailpeanuts 10y agoi agree with your latter point but "very poorly coded" is going too far. He made something that works (although I was a bit underwhelmed as well), and shared it here. Give him some credit. Maybe instead of just outright saying "exhibit 1,2,3,4 on how shitty this guy's code is", you can give constructive feedback or send a pull request if you are so cautious about code quality.
- JamilD 10y agoIt's interesting that this got so many upvotes so quickly, despite it being something similar to what (I'm sure) most of us wrote when we first started learning about computers and programming. Maybe there's just a demand for a true, text-input, multi-purpose natural language personal assistant on the desktop.
- ehsankia 10y agoI'm guessing (hoping) most people didn't even actually look at what it was? Maybe they assumed it was related / a remake of Zuckerberg's Jarvis? [1] As for demand for it, I'm not sure. Allo tried it, there's also a big wave of chat bots starting to get close to it, but I personally still find it it's simple to just do it myself if I'm already on the computer. At least with voice you can do it hands free. As the person above said, why not just use date instead of "what time is it?" [1] https://www.facebook.com/notes/mark-zuckerberg/building-jarvis/10154361492931634/ https://www.facebook.com/notes/mark-zuckerberg/building-jarv...
- rootlocus 10y ago> As the person above said, why not just use date instead of "what time is it?" Then what would be the difference between using the assistant or using the CLI?
- tpaschalis 10y agoWell, it seems like a catchy title and an image on the project's README.md is enough to get a couple dozens of stars on GitHub.
- nthcolumn 10y agoIt listens, you don't type anything. It isn't multi-threaded so it must break from listening when it hears something and runs through all the if statements, spawns the commands and starts listening again.