4 ms·
The commit that fixes it does not change any tests: https://github.com/zcoinofficial/zcoin/commit/0359bcb2ead7feac5a3a5f6c6581b1b54cda8dd1 https://github.com/z
by electrum 10y ago
The commit that fixes it does not change any tests:
https://github.com/zcoinofficial/zcoin/commit/0359bcb2ead7feac5a3a5f6c6581b1b54cda8dd1 https://github.com/zcoinofficial/zcoin/commit/0359bcb2ead7fe...
This indicates that the code in question is not covered by tests. I work on a database, for which correctness is paramount, so it's unnerving to see any code fixes not associated with test additions or changes. I would have thought that cryptocurrency had similar standards.
- WalterBright 10y agoWe've modified the dlang Github tester to run coverage tests over Pull Requests, and uncovered changes get marked with a scarlet bar. While some changes can't be tested with a test suite, the result has been a marked improvement in the quality of pull requests (including mine) because it is embarrassing to submit untested code.
- unbeli 10y agoI think that won't even compile due to an accidentally pasted URL here: https://github.com/zcoinofficial/zcoin/commit/0359bcb2ead7feac5a3a5f6c6581b1b54cda8dd1#diff-7ec3c68a81efff79b6ca22ac1f1eabbaR775 https://github.com/zcoinofficial/zcoin/commit/0359bcb2ead7fe...
- iMerNibor 10y agoShould compile fine, it'll just evaluate to a goto label named "https" and a comment after