4 ms·
Two things I'm not a fan of so far in the API design. 1) Function names are misleading or not descriptive enough. E.g. isAlpha(). I assumed this meant is alpha
by Negative1 10y ago
Two things I'm not a fan of so far in the API design.
1) Function names are misleading or not descriptive enough. E.g. isAlpha(). I assumed this meant is alphanumeric, but it actually means isAlphabetic (as in no numeric values at all). isAlphanumeric() clears this up, but just call the first isAlphabetic and remove any ambiguity.
2) Explicit binary inverts; e.g. isUppercased(), isLowercased(). This leads to bad coding style as conditionals that point in the affirmative usually leads to easier to read code. If it's not uppercased of course its lowercased, so why keep a function around to point this out? Save on the cognitive load on the users and just keep one around. Let them negate it for the desired result.
Otherwise, thank you for contributing what looks to be a pretty handy library that isn't tied to just MacOS/iOS and Xcode. I'm really starting to enjoy Swift and am curious to use it in non-client environments soon and a library like this is a pretty nice tool to have.
- TazeTSchnitzel 10y ago> 1) Function names are misleading or not descriptive enough. E.g. isAlpha(). I assumed this meant is alphanumeric, but it actually means isAlphabetic Why should it mean alphanumeric? C's isalpha() also tests for being a letter, for instance, and has isalnum() for alphanumericness. > If it's not uppercased of course its lowercased If you're working exclusively with ASCII and ignoring non-letter characters, yes. But is this library bound by those constraints?
- setr 10y agowhat non-letter character should succeed in both isLowercase and isUppercase?
- TazeTSchnitzel 10y agoNone. But letters can be neither lowercase nor uppercase.
- setr 10y agoIn which case, the function(s) should really be throwing some kind of error, since they can't reasonably be applied to the input. But checking !(isUppercase(str) || isLowercase(str)) to see if its not case-able(?) is absurd Obviously you'd instead want the function notCaseable(str).