5 ms·
static char addrbuf[8][NI_MAXHOST]; /* XXX ugly thread-unsafe hack */ /* XXX: assume this succeeds */ inet_ntop(family, addr, cp, NI_MAXHOST);
by maukdaddy 16y ago
static char addrbuf[8][NI_MAXHOST]; /* XXX ugly thread-unsafe hack */
/* XXX: assume this succeeds */
inet_ntop(family, addr, cp, NI_MAXHOST);
- mustpax 16y agoI know we all love to hate Comcast, but you can find similar short-term hacks in any code base. 3 lines of code doesn't necessarily make the rest of released source useless.
- Kadin 16y agoAt least they're honest about it. Calling them out because they were blunt in a comment just encourages them to be more subtle, not necessarily write better code. And particularly in an open-source project, bluntness like that is helpful since it tells other contributors what needs to be replaced ASAP.