3 ms·
A good thought! My point was orthogonal, though. I don't want a reviewer directly making committed changes to my code, period. Giving me control isn't about pr
by unholiness 10y ago
A good thought!
My point was orthogonal, though. I don't want a reviewer directly making committed changes to my code, period. Giving me control isn't about preventing inadvertent calls to sedy. It's about handling when someone suggests a substitution that I don't agree with, or want to reword.
My mindset might be different from what Marmelab intends, but to me, code review is a conversation about the changes I'm responsible for making, not a google doc where anyone can change the content I'm about to push.