4 ms·
I share with fiatjaf's sentiment; this is an amazingly cool piece of hackery (that will probably be very useful to many people), but I won't use it. For those
by LukeShu 10y ago
I share with fiatjaf's sentiment; this is an amazingly cool piece of hackery (that will probably be very useful to many people), but I won't use it.
For those simple types of changes, I like to amend the original commit, rather than make a new one. Of course, I come from using `git send-email` to send patches to a mailing list, where you are expected to send "[PATCH v2]" after you get feedback.
- Kmaschta 10y agoWhat about a command s/[search]/[replace]/a for "--amend"?
- LukeShu 10y agoThat could win me over! I'm not sure what the appropriate answer is to "who should it put in the committer line?" (especially if author and committer are already different), but that's not a huge problem, I don't think.
- pavel_lishin 10y agoIt would be a problem for me - suddenly, my local branch and the Github branch are no longer in sync, and I have to untangle this mess before continuing development. (And if I don't notice that Sedy is changing the revision history, and only realize it when I've made a couple of commits and try to push...)
- hamandcheese 10y agoYou could do an interactive rebase and make all the Sedy commits fixups.
- kngl 10y agoI like the idea. Using `s/foo/bar/f` for a `git commit --fixup` of the last commit who modify this change (only if part of the current PR)